search

earthgecko / skyline

Anomaly detection
http://earthgecko-skyline.readthedocs.io/en/latest/
Other
555 stars 64 forks source link

Unescaped Graphite target #20

Open earthgecko opened 8 years ago

earthgecko commented 8 years ago

Mirage is throwing an error when trying to fetch a timeseries with a ":" in the target name. This probably applies to number of other patterns that may occur in metric namespaces, such as ones that include open/close parenthesis, "(" and ")". Probably all metacharacters, even though ":" is not a metacharacter per se. The also affects Crucible I would think.

2016-08-03 08:34:43 :: 25532 :: graphite url - http://graphite:8888/render/?from=09:31_20160802&until=09:40_20160803&target=carbon.relays.graphite-a.destinations.123_213_124_214:2024:None.relayMaxQueueLength&format=json
2016-08-03 08:34:43 :: 25532 :: surfacing timeseries data for carbon.relays.graphite-a.destinations.123_213_124_214:2024:None.relayMaxQueueLength from graphite from 09:31_20160802 to 09:40_20160803
2016-08-03 08:34:43 :: 25532 :: error :: data retrieval failed

This is in a similar vein to this - https://github.com/graphite-project/graphite-web/issues/242

Fixing Skyline to a Graphite version is probably a step to far :)

earthgecko commented 8 years ago

":" "(" and ")" should now be handled in v1.0.4-crucible-beta.