earthlab-education / ea-lidar-uncertainty-review

A place for code review
MIT License
1 stars 49 forks source link

@csandberg303 minor suggestion to ensure functionality #42

Closed esgeo closed 1 year ago

esgeo commented 2 years ago

@csandberg303

Please see the comments on the code in your PR #28

Review Checklist CI Checks

The notebook runs from start to finish on all operating systems:

Reproducibility

PEP 8 standards & Code Readability Functions

Package imports

Great work, reviewing your code was enjoyable and easy, and was even moreso because Mitchell had already been through it before me!

csandberg303 commented 2 years ago

Thank you Eric! I was fun to have two reviewers, and I thought you had a bit of a complex review when you were commenting on Mitchell's comments, as well as my original code. I appreciate your observations I'm better off because of it.