earthlab / cft

Climate futures toolbox: easy MACA (MACAv2) climate data access 📦
https://www.earthdatascience.org/cft/index.html
25 stars 6 forks source link

Consider adding gridMET #113

Open mbjoseph opened 4 years ago

mbjoseph commented 4 years ago

There are some design decisions to make on this one before we start implementing anything. Here are some options:

  1. Add a source argument to cstdata, which can be either "maca" or "gridmet". There are some existing parameters to cstdata that don't make sense with gridmet, like scenario, and models.

  2. Refactor cstdata to make dataset-specific cstdata functions, e.g., make two functions:

Both of these will return a data frame of files (like we do already for cstdata), that can be passed to cst_df. This interface seems cleaner than option (1) above to me.

What approach would you prefer @WilliamsTravis? Feel free to add suggestions.

mbjoseph commented 4 years ago

Left to do here on the r6_refactor branch which adds support for GridMET: