Closed nkorinek closed 4 years ago
@lwasser @jlpalomino Hey! So I added a very tentative version of the vector lesson. I know we are planning on going over geopandas more in depth later in this course, so I changed the lesson to have less about the functionality of geopandas, aka using plot with matplotlib. I also took out a few cells I thought might go over the students head, like utilizing a for loop to access metadata. All in all, however, I kept MOST of the content from the original lesson. Not sure if I should have took out more, or if you all wanted to keep some sections I cut in.
I added a few interactive activities, just looking at the basics of vector data attributes in geopandas. Obviously very open to notes, but it's at least started!
i'll have a look @nkorinek this is a perfect end of the day thing for me to look at :) thank you. i may make edits so im going to assume you are done working on it for today?
@lwasser No I'll keep working for about an hour today! Getting a bit of a head start on the raster lesson
oops @nkorinek i went ahead and left notes in the vector notebook. i assumed because you pinged me you were not working on that lesson anymore! if it causes big conflicts let me me know.
So a few things
How about this for the future - when you push something up and ping me i am going to assume it's ready for a review which means you are not working on that file anymore. so please don't ping me until you are at a stopping point for that file! it's cool if you continue to work on other files but for the file you ask me to review, i will assume you have stopped working on that specific file and i can edit it directly. does that sound like a plan?
@nkorinek one more thing before i forget !! each of these notebooks should showcase a few different types of data that are often available in this format. So you can use natural earth -- and then maybe ask jenny or find some small downloadable other datasets that contains other types of vector data as demos. so thtere is likely a section on this page like "What types of data are often in spatial vector format" or something like that. you can have a short list including
then the lesson might showcase a few different kinds - showing a few plots that the students maybe modify and then an activity at the end (maybe with natural earth) where you say -- now make this map of x, and x kind of thing.
the metata stuff can be a breakout with links to the intermediate lessons. we can chat more monday but again this is an overview page with a focus on different types of vector (or raster, etc) data showcasing plots and mapping in the interactive activities and demo examples!
@lwasser alright, I've gone through and tried to implement your suggestions for the vector data lesson. The edits made sense, and I hope that I did it somewhat like how you envisioned. Open to any feedback. I still need to write the tests for the new interactive activities, but you should be able to review this notebook/make edits without my test writing interrupting.
@nkorinek UPDATE: i'm about 1/2 maybe more through the vector lesson edits. i suggest not working on it until i'm done as i'm doing a fairly significant overhaul of it. i think we should create a second activity using census data if there is a dataset we can use somewhere. to demo a second kind of data. anyway more later. i started work at 7am today so i could run when it wasn't raining (now!!). i'll be back in a bit. (~1.5 hours)
@lwasser I reviewed the tabular notebook and it is looking good! I left your to-dos, etc, as unfortunately, I do not have time at this moment for more than an overall review.
I fixed a few typos and added hyperlinks in a few places where you highlighted a need. Other than that, no major comments or suggestions, as I think the activity are coming together nicely. I will look at the vector notebook next.
@lwasser The vector notebook is also looking good. Again, fixed a few typos and added a few links, etc. Overall, I really like the activities.
I do wonder about the last bonus activity on clipping though. I understand it is intended for more advanced students but it may discourage the others who reach that point successfully and thought they were getting a hang of it all? Just a thought.
@jlpalomino sure - tell me more? do you think it will be hard for them to understand what clipping does? i wanted to provide one simple geoprocessing demo in the notebook. open to any suggestions. we just though clip was simple enough as it's just one line of code and we give them the code ... but i guess there is a subset in there too.. let me know!
i've finalized the tabular notebook! and can work on this next.
@lwasser @jlpalomino sorry to add more to your plates, but I've pushed up the first draft of the raster lesson. That can be reviewed whenever you get the chance.
ok raster lesson is in! @nkorinek i am going to walk my dog. i'll look at your final activity after that! thank you for all of the help today!
@lwasser sounds good, exercise lesson has been pushed up! If you have any questions about it you can reach me on slack
Starting the data type lesson for week 2 of edsc