earthlab / firedpy

A Python Command Line Interface for classifying fire events from the Collection 6 MODIS Burned Area Product.
MIT License
34 stars 20 forks source link

final intersect is not quite right #71

Closed admahood closed 2 years ago

admahood commented 2 years ago

So, the idea I had, and what the algorithm was previously doing, was to filter the final perimeters to those that had at least some area within the AOI polygon. So, something like if polygon is touching == true, then the whole polygon is included. That way when we include the whole event, even it crosses a political boundary. It looks like there is a clip of the points before they are turned into polygons.

image

EllieLindrooth commented 2 years ago

Is this for the daily events?

admahood commented 2 years ago

it is the daily! so that's actually not the wyoming border

Here are the events, and those look correct:

image

But then here's the daily:

image

So it looks like the final intersects thing does not happen for the daily.

Just a thought, but maybe in the workflow, it might actually make sense to basically just save a vector of id numbers for the final events polygon that gets written out, then just filter by that to save out the daily polygons. That might actually be faster than doing the geometric operation twice.

admahood commented 2 years ago

Another thought is that whatever that initial buffer is can probably be cut in half