earthlab / firedpy

A Python Command Line Interface for classifying fire events from the Collection 6 MODIS Burned Area Product.
MIT License
36 stars 20 forks source link

geometry is off by a half pixel #76

Closed admahood closed 2 years ago

admahood commented 2 years ago

small_event_figure

So, if you look at firedpy s1 t5, it's off by half a pixel. This is something that is probably in the create polygons function at the end.

Double check first against a HDF template. i.e. look at a raw tif file that's derived from an HDF (template.tif can be used in the data_paper_files folder), and make sure the pixels are lined up right. I think there is a position shift that might need to be done for the points before they're turned into polygons (+ or - half the resolution for x and y)

admahood commented 2 years ago

Might be a good first issue for ryan to tackle

admahood commented 2 years ago

need to check if this is true for all of the derived products or just CONUS-AK. Back story, the firedpy s5t11 is the 2019 version, the s1t5 is the 2021 version

admahood commented 2 years ago

need to add

x - (res/2) y+ (res/2)