Base Test Coverage and Test Organization

[marty-larocque]

This pull request does a number of things.

• Adds some tests for the base module, mostly for assert_xydata(), addressing issue #101
• Renames tests that shared names with other tests, causing only one to be defined and run. This addresses issue #101
• Refactors assert_xydata() for clarity
• Moves the test test_correct_title() to test_base_titles_captions.py, addressing issue #115
• Moves all the tests for assert_xydata() to test_base_data.py, addressing issue #114

[codecov[bot]]

Codecov Report

Merging #112 into master will increase coverage by 1.84%. The diff coverage is 85.39%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   58.04%   59.89%   +1.84%     
==========================================
  Files          14       16       +2     
  Lines        1230     1279      +49     
==========================================
+ Hits          714      766      +52     
+ Misses        516      513       -3

Impacted Files	Coverage Δ
matplotcheck/tests/test_base_data.py	100% <100%> (ø)
matplotcheck/tests/test_base_titles_captions.py	100% <100%> (ø)	:arrow_up:
matplotcheck/tests/test_base.py	100% <100%> (+4.76%)	:arrow_up:
matplotcheck/tests/test_ts_data.py	100% <100%> (ø)
matplotcheck/tests/test_base_axis.py	100% <100%> (+1.63%)	:arrow_up:
matplotcheck/tests/conftest.py	75.38% <26.66%> (-14.62%)	:arrow_down:
matplotcheck/base.py	83.47% <88.23%> (+4.23%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f318e77...1d091a0. Read the comment docs.

[marty-larocque]

@lwasser Could you take a look at this?

[marty-larocque]

@lwasser The for loop and .iloc[] were temporary things I'd put in for debugging. I'm pretty confused how they ended up in the most recent commit, as I deleted them a couple commits ago, but they should be gone now.

[lwasser]

ok @ryla5068 this all looks great. i ddi some testing of black locally. for some reason it's not formatting the docstrings using the 79 character line length. i'm not sure why but let's just ensure the code is 79 characters is less long including the docstrings. i'll create an issue surrounding this but you can adjust the code manually for this pr. once you are done with the fixes, please ping me here again and i'll give this another review (and will likely merge as my comments are very small!!)

[lwasser]

a few other question

• [ ] https://codecov.io/gh/earthlab/matplotcheck/pull/112/diff?src=pr&el=tree#D3-683 i am wondering if the test for this doesn't have match= to rest that the error message is raised?

[marty-larocque]

@lwasser I think I've fixed everything here.

• For the commented-out tests:
  • The geodata test was not a working or substantial test, so I deleted it.
  • I moved the timeseries test to test_ts_data.py, but left it commented out.
• I couldn't follow the link you gave to the pytest.raises() call without a match=, but I added a match= to a couple tests in test_base.py. I believe every test in that file and intest_base_data.py has a match= now.
• I added docstrings to the fixtures
• I changed all the docstrings in base.py to have the correct length lines
• Regarding the codecov link you sent me (base.py:683), that line just does not have a test right now. That should be addressed in a future pr.

[lwasser]

excellent work on this PR @ryla5068 !!! i'm going to let CI run and will then merge this.