earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!

https://matplotcheck.readthedocs.io

BSD 3-Clause "New" or "Revised" License

18 stars 8 forks source link

Fixes to the data and text string methods, updated changelog and tests for base #128

Closed marty-larocque closed 4 years ago

marty-larocque commented 5 years ago

This PR addresses a number of issues uncovered in an example usecase for matplotcheck:

Updates the changelog to address issue #130
Revamps all string_contains assertions in base module. This addresses issue #132
- This effectively resolves issue #109 by creating a new system and syntax for string_contains functions
Fixes assert_xydata() incorrectly failing on some floating point numbers (issue #133)
Rewrites allows assert_xlabel_ydata. The function now:
- Evaluates wether x-labels are text strings, numeric strings, numbers, or something else
- Intelligently decides which comparison to use based on type of x-labels
- Addresses issue #134
Rewrites get_caption() and the functions that call it so that get_caption() returns a string. This addresses issue #135

codecov[bot] commented 5 years ago

Codecov Report

Merging #128 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files          16       16           
  Lines        1405     1405           
=======================================
  Hits          887      887           
  Misses        518      518

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b4abfc...0b4f157. Read the comment docs.

marty-larocque commented 4 years ago

@lwasser I believe I fixed everything. I fixed some docstringsm, added new ones where they didn't exist, and added two (four, technically) fixtures in test_base_data.py. however, it looks like Travis is failing because of black.

lwasser commented 4 years ago

ok @ryla5068 this all looks good.i'm working on a travis fix right now over in earthpy. if it works there i'll implement it here. if it fixes things i'll move it over here as well. this PR is ready to merge otherwise. i'll ping you when you need to update this PR from master

lwasser commented 4 years ago

ok @ryla5068 please fix the conflicts here and update from master. Everything is passign Ci now. and i was able to fix the test_base_data.py black issues as well.

lwasser commented 4 years ago

@ryla5068 i just merged this!! so all you need to do is update your other PR from master for the vignette and i'll look at it tomorrow. so happy CI is happy now!