search

earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

a fix to the black url for the precommit hook #145

Closed lwasser closed 4 years ago

lwasser commented 4 years ago

This PR addresses #144 but also a bit more.

  1. black was not install properly in CI and that it turns out was due to the version of pip available in the tox envt where black was installed.
  2. runs black on test_base_data.py which for some reason had format issues.
  3. updates the url for black in the pre commit setup.

All is building well now and this should fix other pr's including both of @ryla5068 's active PR's once merged!!

codecov[bot] commented 4 years ago

Codecov Report

Merging #145 into master will increase coverage by 3.24%. The diff coverage is 96.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   59.89%   63.13%   +3.24%     
==========================================
  Files          16       16              
  Lines        1279     1405     +126     
==========================================
+ Hits          766      887     +121     
- Misses        513      518       +5
Impacted Files Coverage Δ
matplotcheck/tests/test_base_data.py 100% <100%> (ø) :arrow_up:
matplotcheck/tests/test_base_titles_captions.py 100% <100%> (ø) :arrow_up:
matplotcheck/tests/test_base.py 100% <100%> (ø) :arrow_up:
matplotcheck/tests/test_base_axis.py 100% <100%> (ø) :arrow_up:
matplotcheck/base.py 83.82% <92.18%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67ca0a2...271bb50. Read the comment docs.