search

earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Passsing assert_polygons a GeoDataFrame #175

Closed nkorinek closed 4 years ago

nkorinek commented 4 years ago

If a GeoDataFrame is passed into VectorTester.assert_polygons() as the polygons_expected, the test fails bc it is not a list of coordinates. There is a helper function called _convert_multipolygons that properly converts the GeoDataFrame into a list of coordinates. However, it is not called in the assert_polygons() function. There should be a check to see if the input is a GeoDataFrame and if it is the function _convert_multipolygons should be called within the function assert_polygons(). @lwasser

nkorinek commented 4 years ago

pr here: https://github.com/earthlab/matplotcheck/pull/188

nkorinek commented 4 years ago

Merged!