earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Add flake8 & Format Files to be compliant #196

Closed lwasser closed 4 years ago

lwasser commented 4 years ago

@nkorinek i'm adding flake8 here... be prepared to catch a LOT of other things we've missed!!

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@936980a). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage          ?   69.63%           
=========================================
  Files             ?       17           
  Lines             ?     1561           
  Branches          ?        0           
=========================================
  Hits              ?     1087           
  Misses            ?      474           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 936980a...fefb293. Read the comment docs.

lwasser commented 4 years ago

@nkorinek i merged this locally. there were a bunch of merge conflicts! please in the future

  1. be sure that a PR is a WIP until it passes CI and there are NO MERGE CONFLICTS! then i will look at it
  2. before doing any editing always update from the branch that you are working on! I think we have one file left: base to edit!! i'll let you do that tomorrow or monday whenever you have time!

Thank you for your work on this.

nkorinek commented 4 years ago

@lwasser sorry!! That's my mistake, I'll try to be more careful in the future

lwasser commented 4 years ago

closign this as i believe it was merged in another pr