search

earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Add flake8 fix #199

Closed nkorinek closed 4 years ago

nkorinek commented 4 years ago

Resolving merge conflicts (hopefully)

codecov[bot] commented 4 years ago

Codecov Report

Merging #199 into master will decrease coverage by 0.05%. The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   69.74%   69.68%   -0.06%     
==========================================
  Files          17       16       -1     
  Lines        1560     1557       -3     
==========================================
- Hits         1088     1085       -3     
  Misses        472      472
Impacted Files Coverage Δ
matplotcheck/tests/test_base_titles_captions.py 100% <ø> (ø) :arrow_up:
matplotcheck/tests/test_base_axis.py 100% <ø> (ø) :arrow_up:
matplotcheck/notebook.py 0% <ø> (ø) :arrow_up:
matplotcheck/cases.py 0% <ø> (ø) :arrow_up:
matplotcheck/tests/test_base.py 100% <ø> (ø) :arrow_up:
matplotcheck/autograde.py 0% <ø> (ø) :arrow_up:
matplotcheck/folium.py 0% <ø> (ø) :arrow_up:
matplotcheck/tests/test_base_data.py 100% <ø> (ø) :arrow_up:
matplotcheck/raster.py 100% <ø> (ø) :arrow_up:
matplotcheck/vector.py 31.64% <0%> (-0.21%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6deb54...165afd6. Read the comment docs.

nkorinek commented 4 years ago

@lwasser this is finally passing Travis! It's still failing Codacy (would you like me to fix that? It's just failing some section titles it thinks are mis-placed) but aside from that it's looking good!

nkorinek commented 4 years ago

Codacy failing due to header's triggering the String statement has no effect error, which I believe is soon to be fixed/has already been fixed, correct? If not, it should be fixed soon or the way we handle headers should change.

AppVeyor is failing due to an environment issue it looks like. The error message is 

UnsatisfiableError: The following specifications were found to be in conflict:
  - matplotlib >=3.0.0
  - rasterio

Unsure how to fix this one!

lwasser commented 4 years ago

@nkorinek ahhhh there were some issues last week with things not resolving correctly. let me try to rerun appveyor today codacy i'm not sure what is going on!

lwasser commented 4 years ago

@nkorinek i see what is going on with codacy. it doesn't like the """section here""" i just posted on slack about this but if you have a bit of time could you look into best practices here? i like breaking up the code but maybe we want to just use a single comment? altho i don't know if codacy will like that either. CI is rerunning.