earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Additional vector tests #212

Closed nkorinek closed 4 years ago

nkorinek commented 4 years ago

Have to merge https://github.com/earthlab/matplotcheck/pull/203 before this one.

codecov[bot] commented 4 years ago

Codecov Report

Merging #212 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files          18       18           
  Lines        1747     1747           
=======================================
  Hits         1356     1356           
  Misses        391      391           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44f4334...44f4334. Read the comment docs.

mbjoseph commented 4 years ago

Heya @nkorinek - not 100% sure whether this is a fix, but do you need to set the matplotlib backend to get these commented out tests to work? e.g., in test_vector.py at the top:

... # other imports
import matplotlib
matplotlib.use('Agg')

# awesome tests
...
nkorinek commented 4 years ago

@lwasser Alright I think I'm happy with how much of the code is tested now! Let me know what you think and if I need to look into adding anymore vector tests.

lwasser commented 4 years ago

Heya @nkorinek - not 100% sure whether this is a fix, but do you need to set the matplotlib backend to get these commented out tests to work? e.g., in test_vector.py at the top:

... # other imports
import matplotlib
matplotlib.use('Agg')

# awesome tests
...

THANK YOU @mbjoseph !! so appreciative of your help!

nkorinek commented 4 years ago

Ok @lwasser , I went through and renamed variables you pointed out had confusing names, and hopefully clarified a lot of the confusion. I think this is ready for another review!

lwasser commented 4 years ago

ok once CI finishes I will merge this!!