earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!

https://matplotcheck.readthedocs.io

BSD 3-Clause "New" or "Revised" License

18 stars 8 forks source link

Add assert_polys_grouped_by function #240

Closed nkorinek closed 3 years ago

nkorinek commented 4 years ago

Added a function to test that polygons were grouped by a certain attribute, much like the functions we have that do this for lines and points. Also added some tests. This pr addressed issue #225. I can add this function to our vector vignette once this https://github.com/earthlab/matplotcheck/pull/220 pr is merged.

codecov[bot] commented 4 years ago

Codecov Report

Merging #240 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files          19       19           
  Lines        1883     1883           
=======================================
  Hits         1513     1513           
  Misses        370      370

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22cc31f...22cc31f. Read the comment docs.

nkorinek commented 4 years ago

@lwasser here for review whenever you get the chance!

lwasser commented 4 years ago

thank you @nkorinek what assignment were you testing this on? i just want to test it locally. maybe one of the vector assignments?

nkorinek commented 4 years ago

@lwasser ya I would test this on the clip assignment, towards the end, when there are the polygons with the values based on land/water area.