earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!

https://matplotcheck.readthedocs.io

BSD 3-Clause "New" or "Revised" License

18 stars 8 forks source link

Test coverage for lines #274

Closed nkorinek closed 4 years ago

nkorinek commented 4 years ago

This pr is a blend of https://github.com/earthlab/matplotcheck/pull/239 and https://github.com/earthlab/matplotcheck/pull/248 . It changes how the lines are checked for coverage and adds tests for the lines new checks. It's WIP because it still needs new tests added to it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #274 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          21       21           
  Lines        1943     1943           
=======================================
  Hits         1614     1614           
  Misses        329      329

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f35181b...f35181b. Read the comment docs.

nkorinek commented 4 years ago

@lwasser hey! This pr is ready for review now. I added in the tests. Sorry it took so long, I tried out a few different ways to test the new functionality that failed pretty miserably.

Also, for some reason flake8 failed a bunch of variable names on this pr that it wasn't failing before (rightfully so, they were bad variable names), so I had to make changes to other files such as vector.py and timeseries.py to make flake8 pass.