earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!

https://matplotcheck.readthedocs.io

BSD 3-Clause "New" or "Revised" License

18 stars 8 forks source link

Update dependencies #304

Closed nkorinek closed 4 years ago

nkorinek commented 4 years ago

Updating dependencies to be the most recent versions of the tool.

lwasser commented 4 years ago

@nkorinek it looks like this is failing because of the pre-commit version bump. what i suggest is that you

try to remove that update here and if everythign passes we can merge what is passing.
leave the pre-commit broken pr from the bot open as well and we can look into this issue in the future - perhaps add an issue on it. that way we can update everything else, close associated other pr's and come back to this one update later.

nkorinek commented 4 years ago

@lwasser just fyi I was looking at this pr again and it seems like the appveyor ran into an issue and needs to be re-run. I tried to do it but I either don't have the permissions or am not seeing the button

codecov[bot] commented 4 years ago

Codecov Report

Merging #304 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          21       21           
  Lines        1943     1943           
=======================================
  Hits         1614     1614           
  Misses        329      329

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5e189f...31f2c86. Read the comment docs.

nkorinek commented 4 years ago

@lwasser reverted pip here and it fixed the pr, ready to merge!

lwasser commented 4 years ago

@nkorinek great. PIP upgrades have been consistently problematic so i've mostly closed those PR's :) thank you for this. merging