search

earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Matplotcheck build fix #335

Closed nkorinek closed 4 years ago

nkorinek commented 4 years ago

Fixing issues causing matplotcheck builds to fail.

codecov[bot] commented 4 years ago

Codecov Report

Merging #335 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          21       21           
  Lines        1943     1943           
=======================================
  Hits         1614     1614           
  Misses        329      329
Impacted Files Coverage Δ
matplotcheck/base.py 96.10% <ø> (ø)
matplotcheck/cases.py 0.00% <ø> (ø)
matplotcheck/notebook.py 0.00% <ø> (ø)
matplotcheck/tests/test_lines.py 93.67% <ø> (ø)
matplotcheck/tests/test_polygons.py 91.66% <ø> (ø)
matplotcheck/vector.py 89.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e6ba14...b9fe17f. Read the comment docs.

nkorinek commented 4 years ago

@lwasser this is good to merge too! I think I fixed the issues here.

lwasser commented 4 years ago

you rock! @nkorinek what was the issue? i'll merge but i'd still like to know just for future :)

nkorinek commented 4 years ago

@lwasser there were three issues. One was that a link died b/c the website updated from http: to https:. The se

cond issue was make docs having a hard time parsing one of our docstrings for some reason (it said “Inline literal start-string without end-string”, which I couldn't see any strings that matched that description). I added a return in the affected area and that seemed to fix whatever issue it was having.

The third issue was black updated and caught some new formatting issues it didn't check for before. This one slipped by bc black updated here but not on my pc so had to update it locally to catch those same errors