search

earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Tests for raster module #34

Closed kysolvik closed 5 years ago

kysolvik commented 5 years ago

Working on adding tests for the raster module (#32). Will update when finished

kysolvik commented 5 years ago

Build failed because I forgot to activate pre-commit hook/run black. Will fix!

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into master will increase coverage by 14.07%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #34       +/-   ##
===========================================
+ Coverage   32.96%   47.03%   +14.07%     
===========================================
  Files          11       12        +1     
  Lines         904     1029      +125     
===========================================
+ Hits          298      484      +186     
+ Misses        606      545       -61
Impacted Files Coverage Δ
matplotcheck/tests/test_raster.py 100% <100%> (ø)
matplotcheck/raster.py 100% <100%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b64e14...becf061. Read the comment docs.

kysolvik commented 5 years ago

Hi @lwasser,

This PR is ready for review but no rush. I'll start working on the base module tests in the meantime. Thanks!!

lwasser commented 5 years ago

awesome thank you @kysolvik i ran out of time today but i'll be sure to review this when i'm back next week!!!

kysolvik commented 5 years ago

Probably going to fail appveyor because of the pip problem, will update once #47 is merged