search

earthlab / matplotcheck

A python package for checking and testing matplotlib plots. We use this for autograding student assignments but there are many other potential use cases including package testing (for packages with plots)!
https://matplotcheck.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

Updates to legend tests #55

Closed lwasser closed 5 years ago

lwasser commented 5 years ago

this PR building upon @kysolvik existing pr . also doing a bit of function and readme cleanup as i go to clarify process!

codecov[bot] commented 5 years ago

Codecov Report

Merging #55 into master will increase coverage by 9.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #55     +/-   ##
=========================================
+ Coverage   14.82%   23.93%   +9.1%     
=========================================
  Files           9       10      +1     
  Lines         823      844     +21     
=========================================
+ Hits          122      202     +80     
+ Misses        701      642     -59
Impacted Files Coverage Δ
matplotcheck/tests/test_base_legends.py 100% <100%> (ø)
matplotcheck/base.py 39.4% <100%> (+15.96%) :arrow_up:
matplotcheck/tests/conftest.py 89.79% <0%> (+12.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51dd61a...95857b0. Read the comment docs.

lwasser commented 5 years ago

letting CI build but if all builds well, this can be merged! all legend asserts are tested via this PR. this addressing this issue https://github.com/earthlab/matplotcheck/issues/38