search

earthly / earthly-emacs

Major mode for editing Earthly Earthfile
Mozilla Public License 2.0
18 stars 8 forks source link

Integrating to LSP #12

Open wingyplus opened 3 years ago

wingyplus commented 3 years ago

I think we should add lsp-mode integration support to the emacs. Maybe we should provide a minor mode (earthly-lsp I think..) that implement lsp client from lsp-mode. The experiment lsp server might be https://github.com/andrewsykim/earthly-lsp.

Ref to discussion https://github.com/earthly/earthly-emacs/issues/9#issuecomment-917067813

Konubinix commented 3 months ago

There is also https://github.com/glehmann/earthlyls now. @glehmann was aware of https://github.com/andrewsykim/earthly-lsp but wanted to create the lsp server in rust.

So far, I can tell he did pretty well. Also, he it still very eager to develop new features.

Also, you actually don't need to do anything to support lsp in this repository. I already added the support for https://github.com/glehmann/earthlyls in lsp-mode. You only need to enable lsp from your earthlfiles and then, you can get this.

image

instead of this

image

And goto-reference and find-references as well

image