search

earthly / earthly-emacs

Major mode for editing Earthly Earthfile
Mozilla Public License 2.0
18 stars 9 forks source link

Linting package on CI #6

Closed wingyplus closed 2 years ago

wingyplus commented 2 years ago

This changes introduce Eldev to uses for lingting the package and add Earthfile to run Eldev inside the container. And add GitHub workflow to run linting against Earthly.

The CI workflow run on 2 Emacs version, 26 which's minimum support and 27 which's latest stable version.

You can see an example here.

Closes #5

wingyplus commented 2 years ago

@vladaionescu request reviewing. :)

vladaionescu commented 2 years ago

Hi @wingyplus - sorry for the delay. Will take a look at this next week most likely since I need to adjust some CI-related permissions first.

(Separately, I've given you write access to this repo so you can manage/review any incoming PRs yourself directly if needed. We should aim for at least 1 PR review, and ideally, any new contributions should be manually tested by the reviewer as well, to make sure the package is not broken. Thanks for making Earthly better!!)

wingyplus commented 2 years ago

Hi @wingyplus - sorry for the delay. Will take a look at this next week most likely since I need to adjust some CI-related permissions first.

(Separately, I've given you write access to this repo so you can manage/review any incoming PRs yourself directly if needed. We should aim for at least 1 PR review, and ideally, any new contributions should be manually tested by the reviewer as well, to make sure the package is not broken. Thanks for making Earthly better!!)

@vladaionescu Thank you for your invitation. ^^

wingyplus commented 2 years ago

And this PR is just nice to have at the moment, review it when you have a free time. :)

wingyplus commented 2 years ago

Sorry for the delay. I would like to merge this and will refactor after that since I accidentally remove the fork repo both my github account and local machine. 🙇