search

earthly / earthly-intellij-plugin

Mozilla Public License 2.0
9 stars 7 forks source link

Migrate to antlr lexer/parser #35

Closed ingwarsw closed 6 months ago

ingwarsw commented 6 months ago

That PR is just "partially" working attempt to migrate to antlr lexer/parser. Its not working because I was not able to make lexer working properly.

I opened it to have idea" how to make it in the future.. Only relevant commits here are https://github.com/earthly/earthly-intellij-plugin/pull/35/commits/f78f2b319e435844156caec1c630c058a7150015 and https://github.com/earthly/earthly-intellij-plugin/pull/35/commits/8c312522502e03e97ea0e1a185136b379b60532e

Just for the future.. Lexer/parser was working except for.

IDENT/DEDENT setup.. Some random errors Discontinuous sequence of tokens is generated by lexer

idelvall commented 6 months ago

Thanks @ingwarsw! give me a couple of days to take a look

ingwarsw commented 6 months ago

@idelvall @idodod Thats bad PR.. that one is not working and its just for future use.. Proper one is #34