search

earthly / earthly

Super simple build framework with fast, repeatable builds and an instantly familiar syntax – like Dockerfile and Makefile had a baby.
https://earthly.dev
Mozilla Public License 2.0
11.48k stars 404 forks source link

Ruby on rails example #344

Closed adamgordonbell closed 3 years ago

adamgordonbell commented 4 years ago

We need an example rails application added to the examples folder: https://github.com/earthly/earthly/tree/master/examples

An example Earthfile should also be included which can build, test, and produce a docker file of the example.

The Go example can serve as a reference point for how to structure an example.

RajivSah commented 4 years ago

Can I take this?

adamgordonbell commented 4 years ago

Hi @RajivSah, you certainly can. Let me know if you have any questions or jump on our Gitter channel: https://gitter.im/earthly-room/community

RajivSah commented 4 years ago

Thanks.

RajivSah commented 4 years ago

Wouldn't setting up new rails app in the example folder create multiple files as the new rails project contains a lot of files?

zedtux commented 4 years ago

Well, for Python (the closest to Ruby) and the others, there's no featured framework, why would it be for Ruby?

I guess @agbell meant Ruby, not Rails.

adamgordonbell commented 4 years ago

Hi @zedtux and @RajivSah , I was thinking an actual ruby on rails example. I also put a ticket in for a django example. The problem we are trying to solve here is somebody has a rails project and is considering using early to run the tests and containerize it, we want to give them an example that they can work off of. I think a small ruby example would also be useful.

zedtux commented 4 years ago

@RajivSah will you do Ruby, Rails or both?

RajivSah commented 4 years ago

The ruby example has been merged, I am working on rails as well.

Gauravsaha-97 commented 4 years ago

I would like to work on this issue.

RajivSah commented 4 years ago

I would like to work on this issue.

You can take it if you want.

Gauravsaha-97 commented 4 years ago

@RajivSah Created a PR

zedtux commented 4 years ago

@Gauravsaha-97 I believe you messed up with your PR #371 as it contains the same code (The C example) than the PR #369.

Can you please double check?

Gauravsaha-97 commented 4 years ago

Actually, I messed up with the commit message. The code in the two PRs are different. I dont know how to edit the commit message.

On Sun, Oct 4, 2020, 13:37 Guillaume Hain notifications@github.com wrote:

@Gauravsaha-97 https://github.com/Gauravsaha-97 I believe you messed up with your PR #371 https://github.com/earthly/earthly/pull/371 as it contains the same code (The C example) than the PR #369 https://github.com/earthly/earthly/pull/369.

Can you please double check?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/earthly/earthly/issues/344#issuecomment-703219356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGVVNCRSD7SMCX27OJTMUTSJAUNVANCNFSM4R6FDGAA .

zedtux commented 4 years ago

Okay, sorry, you're right. The PR #371 has both Ruby and C examples because its branch is a child of #369.

Have look at Changing a commit message from Github's documentation.

Gauravsaha-97 commented 4 years ago

I have changed the commit message.

On Sun, Oct 4, 2020, 15:30 Guillaume Hain notifications@github.com wrote:

Okay, sorry, you're right. The PR #371 https://github.com/earthly/earthly/pull/371 has both Ruby and C examples because its branch is a child of #369 https://github.com/earthly/earthly/pull/369.

Have look at Changing a commit message https://docs.github.com/en/free-pro-team@latest/github/committing-changes-to-your-project/changing-a-commit-message from Github's documentation.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/earthly/earthly/issues/344#issuecomment-703231758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGVVNDV7GN62QICF57TF7LSJBBVVANCNFSM4R6FDGAA .