earthly / lib

Mozilla Public License 2.0
7 stars 11 forks source link

Remove target locking #43

Closed idelvall closed 6 months ago

idelvall commented 7 months ago

This PR removes the locking in target mount, and also introduces a single target mount as opposed to one per target as we had before.

This PR removes the fingerprinting deletion code, (now --keep-ts will be required in COPY commands), and the responsibility of ensuring that the artifacts of concurrent builds do not overwrite each other is left to the user.

This results in a simpler API, and a reduced cache usage

idelvall commented 6 months ago

I was assuming that Cargo locking was more fine gained (for target) than it apparently it is: https://github.com/rust-lang/cargo/pull/2486. Looks like target folder is locked globally so, we definitely don't want such limitation in Earthly builds.