search

earthly / lib

Mozilla Public License 2.0
7 stars 11 forks source link

Fix --output in some cases (#53) #54

Closed JohnCMoon closed 5 months ago

JohnCMoon commented 5 months ago

Currently, when --output is used multiple times on the same directory, the underlying command which copies the output can fail with a misleading error message. Even if your regular expression matches a file in the target directory, you're presented with:

"no files found within ./target matching the provided output regexp"

If the "mv" command's stderr is printed, it shows:

"mv: inter-device move failed: '/tmp/earthly/lib/rust/release' to 'target/release'; unable to remove target: Directory not empty"

Since "mv" doesn't handle existing directories the way we may want here, let's use "cp -ruT" to overlay the files into the target directory (regardless of what's already present there) and then remove the temporary directory.

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

idelvall commented 5 months ago

Nice picture BTW!