search

earthobservations / wetterdienst

Open weather data for humans.
https://wetterdienst.readthedocs.io/
MIT License
356 stars 54 forks source link

Refactor index caching -> Remove monkeypatch for fsspec #1242

Closed gutzbenj closed 7 months ago

gutzbenj commented 7 months ago

Dear @provinzkraut ,

thanks for the pushing! Got it to work much nicer now! Still will be looking into the fsspec PR to get it officially as a feature there.

provinzkraut commented 7 months ago

Hi @gutzbenj, thanks for the quick turnaround on this! The new approach is exactly what I was talking about in my comment on the other PR! This saves me from having to carefully un- and then re-patch fsspec :)

gutzbenj commented 7 months ago

You're right though the way it has to be done is currently not so nice (overwriting an existing attribute manually...). Still cleaner then before :-D