earthobservations / wetterdienst

Open weather data for humans.
https://wetterdienst.readthedocs.io/
MIT License
347 stars 54 forks source link

Bump environs from 10.0.0 to 11.0.0 (2024-03-04) #1319

Closed lpegel closed 1 month ago

lpegel commented 1 month ago

Is your feature request related to a problem? Please describe. Fixes: Prevent DeprecationWarning getting raised by marshmallow 3.21.0 (:issue:333).

Describe the solution you'd like environs = ">=9.4.0,<12"

Additional context ! Be Aware: Other changes in environs:

Remove subcast_key argument of env.dict. Use subcast_keys instead.
Bump minimum required marshmallow version to 3.13.0.
Remove missing argument from Env methods. Use default instead.
Remove subcast argument from Env methods that don't use it.
Backwards-incompatible: Remove environs.__version__ variable. Use importlib.metadata.version("environs") instead.
gutzbenj commented 1 month ago

Dear @lpegel ,

I'm sorry but I'm not sure what you are talking about! There's currently no environs>11.0.

lpegel commented 1 month ago

Hi Benjamin,

yes you are right. My described solution is merely an analogy to the commit changing environs 9.5 to 10.0.0. As you can see here : https://github.com/earthobservations/wetterdienst/commit/5daec354f9b544ebb7799109cc783303b53e08bb As for as my understanding goes the proposed solution allows all versions greater than or equal to 9.4.0 and less than 12.

The header of the issue is the actual issue and solution i would like to humbly ask to change:

Please allow environs 11.0.0 (2024-03-04) as a dependency. see: https://github.com/sloria/environs/blob/main/CHANGELOG.md

Beste Grüße Lutz

By the way: i relay love the work you are guys doing and enjoy the package very much. It is very helpful. So thank you very much.

gutzbenj commented 1 month ago

Sorry my bad, eyes apparently didn't work that day!

The new wetterdienst release comes with a bumped upper bound for environs. Not sure why dependabot didn't propose bumping environs as the version was already out several months.