search

earthobservations / wetterdienst

Open weather data for humans.
https://wetterdienst.readthedocs.io/
MIT License
349 stars 54 forks source link

Old attribute name in README code example #296

Closed joroeder closed 3 years ago

joroeder commented 3 years ago

Describe the bug The code example of the READMe is not running. Old humanize_column_names attribute name (See https://github.com/earthobservations/wetterdienst/blob/main/README.rst#synopsis) (wetterdienst v0.12.0)

To Reproduce Steps to reproduce the behavior: Test example of https://github.com/earthobservations/wetterdienst/blob/main/README.rst#synopsis

Expected behavior Attribute error is raised.

If I am mixing up versions, sorry for opening this issue. This is the first time I am using wetterdienst. Btw, thanks for this nice initiative!

amotl commented 3 years ago

Hi Johannes,

thanks for reporting this flaw. You are right, according to the examples like [1], the parameter name apparently is called humanize_parameters these days. That has probably changed while working towards the current 0.12.0 release. Apologies!

We will have to update the documentation accordingly. Currently, I can find two references still mentioning the old name [2].

Btw, thanks for this nice initiative!

Thanks, we appreciate it. We will be happy when you spread the word and if you leave us a star.

With kind regards, Andreas.

[1] https://github.com/earthobservations/wetterdienst/blob/v0.12.0/example/observations_sql.py#L29-L37 [2] https://github.com/earthobservations/wetterdienst/search?q=humanize_column_names&type=code