search

earthobservations / wetterdienst

Open weather data for humans.
https://wetterdienst.readthedocs.io/
MIT License
349 stars 54 forks source link

Running tests without Wetterdienst Explorer UI #423

Closed amotl closed 1 year ago

amotl commented 3 years ago

Hi,

while poe test -m "not ui" is advertised ^1, in order to run the tests without having the geckodriver package installed, it currently does not work because we are using the line addopts = "-vvv --webdriver=Firefox --headless" in pyproject.toml.

We will have to wire things a bit differently in order to make this scenario work as intended.

With kind regards, Andreas.

gutzbenj commented 1 year ago

Dear @amotl,

what again was the issue here?

amotl commented 1 year ago

Hi Benjamin,

I wanted to outline a possibility for users to run the tests while skipping the Explorer tests completely. The intention was to give users a chance to run the major part of the test suite without the obligation to install the geckodriver package on their machines.

However, this plan did not work out, because we are using the --webdriver=Firefox --headless options within the tool.pytest.ini_options:addopts configuration section in pyproject.toml. Because of that, when geckodriver is not installed, the test suite will not even start running, because pytest will instantly croak that those options are unknown. This is unfortunate.

With kind regards, Andreas.

amotl commented 1 year ago

--webdriver and --headless are actually options of dash.testing, and it is always included in tool.poetry.group.test.dependencies, together with webdriver-manager. As we did not get any bad reports from users, I think it will be all good. Closing this now.

References