search

earthobservations / wetterdienst

Open weather data for humans.
https://wetterdienst.readthedocs.io/
MIT License
349 stars 54 forks source link

wradlib: Improve installation recipe when building the Docker "full" image #875

Closed amotl closed 1 year ago

amotl commented 1 year ago

At GH-874, we discovered that the installation of the wradlib package is performed seperately from the package version pinned in poetry.lock. This is why we we were getting a build error ^1, because it installed the most recent wradlib 1.19.0, which apparently has an installation flaw (GH-876).

The issue has been quickly fixed with 2f79c5b87e now, but the situation should be improved by completely getting rid of the separate pip invocation. I currently can't remember why it is there. It would be better to install wradlib as a regular optional dependency of wetterdienst, right?

https://github.com/earthobservations/wetterdienst/blob/40b58000915a34d6b875c9ed4c13bff51831dd82/.github/release/full/Dockerfile#L16-L17

https://github.com/earthobservations/wetterdienst/blob/40b58000915a34d6b875c9ed4c13bff51831dd82/.github/workflows/install.sh#L18

/cc @neumann-nico

amotl commented 1 year ago

We've improved the situation with GH-879.

gutzbenj commented 1 year ago

Wradlib was previously installed decoupled of wetterdienst because it had gdal in its dependencies, and only after Kai had opted out GDAL from wradlib we were able to install it directly via pip. I had also tried to put it as is in pyproject.toml but the --no-deps option was seemingly not available there.