Closed amotl closed 1 year ago
In 1.19 xradar has been added as dependency.
It was added in requirements.txt, I can't immediately see, why this brakes here.
It may be because the pinning of xradar>=0.0.13
is insufficient for an alpha library. It will probably break too quickly, so maybe use exact version pinning instead?
Remark: I don't want to hamper your velocity, just sharing my thoughts. Kudos for conceiving xradar
by the way - I've taken a few glimpses and it looks excellent.
Ah, forget about my suggestion, you've probably synchronised things well, because 0.0.13 is actually the latest release. Sorry for the noise, I will try to come up with a minimal repro if I can find some minutes.
The reason
RUN python -m pip install --no-cache-dir --prefer-binary --no-deps wradlib
--no-deps will miss installing xradar here
xradar is now at 0.0.13, so latest version. Most of the code I've ported verbatim from wradlib to xradar and it is as stable as it gets. I've made sure that wradlib is only affected in the slightest way.
wradlib currently only uses the backend code from xradar, which is not about to change, besides bug fixes. I hope this is a little comforting with regard to the beta status of xradar.
--no-deps
will miss installing xradar here
Oh, thank you so much for spotting this. I missed it. I actually don't know why we have those lines here.
It would be better to install wradlib as a regular optional dependency of wetterdienst there, see GH-875.
It would be better to install wradlib as a regular optional dependency of wetterdienst there, see https://github.com/earthobservations/wetterdienst/issues/875.
I gave it a try with GH-878, but immediately got tripped, and by that, reminded, about the error we are observing then, because we don't use Anaconda on our CI, and the dependency chain wradlib -> Cartopy -> GDAL does not resolve well [^1].
[^1]: I am specifically wondering why wradlib pulls in Cartopy, even though it is only listed as optional dependency, right?
We've improved the situation with GH-879. Thanks again!
Observation
At GH-874, we discovered this on a CI run which accidentally installed wradlib 1.19.0.
-- https://github.com/earthobservations/wetterdienst/actions/runs/4193227334/jobs/7269833277#step:7:1136
/cc @kmuehlbauer