earthobservations / wetterdienst

Open weather data for humans.
https://wetterdienst.readthedocs.io/
MIT License
347 stars 54 forks source link

Packaging: Introduce `versioningit` #932

Open amotl opened 1 year ago

amotl commented 1 year ago

Proposal

Use versioningit.

Details

GH-931 already added versioningit to the Dockerfiles. I recently started using it on one or two projects, and I love it.

References

_Originally posted by @amotl in https://github.com/earthobservations/wetterdienst/pull/931#discussion_r1183095043_

gutzbenj commented 1 year ago

Dear @amotl ,

it doesn't look like it supports poetry at this moment, so we#d have to go with https://github.com/mtkennerly/poetry-dynamic-versioning / https://github.com/mtkennerly/dunamai .

Or would this be the right moment to totally switch to either one of hatch / pdm?

amotl commented 1 year ago

Thanks for the research. If we want to keep a lock file, we can have a look at Hatch or PDM. Also, there is another candidate by Armin Ronacher, only recently released. Or, if we don't necessarily need a lock file, we can also think about going back to native setuptools, as it excellently supports pyproject.toml-based projects today, which wasn't the case when Wetterdienst was started, I believe.

gutzbenj commented 1 year ago

Dear @amotl , I'd still go with hatch or pdm because they have functionalities for creating a venv OOTB. hatch doesn't currently support lock files however it is a tool developed by PyPA which should not be underestimated regarding support that splits upon those tools atm.