earthref / MagIC

EarthRef's MagIC Web Application
https://earthref.org/MagIC
MIT License
8 stars 2 forks source link

Table name is not filled in for some of the example uploads #307

Open moonshoes87 opened 6 years ago

moonshoes87 commented 6 years ago

In the upload feature, csv & tab delimited examples should have "table name" filled in.

This happens when clicking on: Example Tab Delimited or: Example Comma Delimited

screen shot 2018-01-26 at 1 03 14 pm
rminnett commented 6 years ago

Thanks for raising the issue! This behavior is intentional, although it could definitely be more clear to the user. The example files (e.g. "Tab Delimited File with Sites Data.txt") are intended to simulate uploading a such a file. A tab-delimited file with arbitrary column names (rather than a MagIC text file format sites file) wouldn't include the "tab sites" header line to indicate that it's intended for upload to the Sites table: Tab Delimited File with Sites Data.txt

If "tab\tsites\n" is inserted at the beginning of the file: MagIC Text File with Sites Data.txt

then it recognizes it as a MagIC text format file and sets it to upload in the Sites table: image

One thought to improve the experience is to make it more clear what the example file looks like. There's a "Download Original" button on Step 2, but it's not very obvious. Perhaps clicking on the example file button should pop up a message explaining what is about to happen with the "Download Original" button, before continuing to Step 2?

moonshoes87 commented 6 years ago

Ah, I see. Yes, it might be nice to make the "download original” more prominent, as I hadn’t noticed it.

On a related note: when downloading that file, I do notice some formatting oddities. I.e., colons on both sides of the items like citations, and the quotations around “ Extrusive: Igneous “. Is that intentional? Or did PmagPy generate this file, in which case I have some little fixes to make?

3 Hawaii i :DE-BFL: :This study: :" Extrusive:Igneous ": :Lava Flow: :Not Specified: 19.296 204.69 700

On Jan 28, 2018, at 8:45 PM, Rupert notifications@github.com wrote:

Thanks for raising the issue! This behavior is intentional, although it could definitely be more clear to the user. The example files (e.g. "Tab Delimited File with Sites Data.txt") are intended to simulate uploading a such a file. A tab-delimited file with arbitrary column names (rather than a MagIC text file format sites file) wouldn't include the "tab sites" header line to indicate that it's intended for upload to the Sites table: Tab Delimited File with Sites Data.txt https://github.com/earthref/MagIC/files/1672218/Tab.Delimited.File.with.Sites.Data.txt If "tab\tsites\n" is inserted at the beginning of the file: MagIC Text File with Sites Data.txt https://github.com/earthref/MagIC/files/1672216/MagIC.Text.File.with.Sites.Data.txt then it recognizes it as a MagIC text format file and sets it to upload in the Sites table: https://user-images.githubusercontent.com/1182698/35493922-b38f28ae-046b-11e8-8f8d-e0b6ccd117d5.png One thought to improve the experience is to make it more clear what the example file looks like. There's a "Download Original" button on Step 2, but it's not very obvious. Perhaps clicking on the example file button should pop up a message explaining what is about to happen with the "Download Original" button, before continuing to Step 2?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/earthref/MagIC/issues/307#issuecomment-361139228, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwGIqg5x8rUUOh7pvPSOLoJ5Nj-2K6Qks5tPUzhgaJpZM4Ru4Ln.

rminnett commented 6 years ago

@moonshoes87, no those were artifacts from early versions of the upgrade tool, not from PmagPy. I'll tidy those up while I add a message about the example files. Thanks for reminding me!