earthref / MagIC

EarthRef's MagIC Web Application
https://earthref.org/MagIC
MIT License
8 stars 2 forks source link

Enforce lowercase column names in the data model #363

Open rminnett opened 6 years ago

rminnett commented 6 years ago

int_rel_ARM, int_rel_IRM, etc. should be int_rel_arm, int_rel_irm, etc. for consistency.

This requires updating the mapping in Elasticsearch and may impact PmagPy.

The Upload Tool should be able to, if it doesn't already, accept and correct contributions with column names in the wrong case.

rminnett commented 4 years ago

The fix for #476 should support mapping incorrect case (and now correct case even when the column is mixed case like these) to the int_rel_ARM and int_rel_IRM. Do we need to change the column names in the data model by Monday? If so, as you pointed out, we should double-check about the impact on PmagPy first.

njarboe commented 4 years ago

Other can comment, but I would say wait until after Wednesday next week as getting the standalones made and testing out everything else takes some time.