search

earthref / MagIC

EarthRef's MagIC Web Application
https://earthref.org/MagIC
MIT License
8 stars 2 forks source link

Reilly et al. (2016) contribution goes to a page displaying the file instead of an option to download a zip file #501

Closed njarboe closed 4 years ago

njarboe commented 4 years ago

The recent Reilly et al contribution that you attached the measurements to does not allow downloading to a file. It displays the file in the browser and since it is so large takes a long time to load. Did not finish after 5 minutes. Other ones work fine.

njarboe commented 4 years ago

Same problem with the Jones 2020 contribution: magic_contribution_16786.txt

rminnett commented 4 years ago

It should download the zip file when you click on the Download button now: https://earthref.org/MagIC/16798

Should I also zip up 16786? The browser is deciding to display it as text in a tab rather than downloading, but since it's not as big, it should still finish and users can use the browser Save As command.

njarboe commented 4 years ago

The problem was that clicking the download button for those two contributions were displaying a text page instead of popping up a save or open dialogue box. We want consistent behavior and the popup works best. For very large files, we will want to have a rule for when we zip up the data. For now we can just do the ones that have multiple measurement files (like the SQUID ones from MIT). If we get any ones like Reilly et al. (2016) that are over 1GB, we should zip those up also.

Sorry for the not describing the problem more precisely and causing you more work. I'll try to be more exact in the future.

rminnett commented 4 years ago

No problem, it wasn't confusing. It's just that Jones 2020 falls somewhere in the middle: too big to result in an automatic download in the browser (it just shows the text file), but smaller than we would normally consider for zipping up. I can just manually zip up anything that results in the browser displaying it as a text file for now and rely on the API zipping up any download in the future.

On Wed, Apr 8, 2020 at 1:39 PM njarboe notifications@github.com wrote:

The problem was that clicking the download button for those two contributions were displaying a text page instead of popping up a save or open dialogue box. We want consistent behavior and the popup works best. For very large files, we will want to have a rule for when we zip up the data. For now we can just do the ones that have multiple measurement files (like the SQUID ones from MIT). If we get any ones like Reilly et al. (2016) that are over 1GB, we should zip those up also.

Sorry for the not describing the problem more precisely and causing you more work. I'll try to be more exact in the future.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/earthref/MagIC/issues/501#issuecomment-611182539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJAX2RYL2BW452DF6C3CEDRLTOJ7ANCNFSM4MDQE2CQ .

njarboe commented 4 years ago

Ok. Thanks for the info. That sounds like a good plan.