Closed tlowrimore closed 2 years ago
@sgwilym Thanks for the feedback! Regarding the CI failure, it looks like the crypto.test.js
is timing out. That said, I may be incorrect in my interpretation of this error message.
@tlowrimore We have intermittent failures where the crypto test times out. It can be fixed by changing the timeout command-line option to tap
at https://github.com/earthstar-project/earthstar/blob/main/package.json#L31
You can ignore any failures that are just Coveralls (it fails when the number of untested lines of code increases).
I think Coveralls is also failing because it runs npm run test-coverage
which does not have a timeout set up in package.json
This all looks good to me. @sgwilym feel free to merge it if you agree.
Thanks @tlowrimore for the excellent patch! Feel free to join our Discord if you want to discuss anything with us.
What's the problem you solved?
Added ability to copy documents from one workspace to another, as described in issue #74. This solution ensures the author's identity cannot be changed and that timestamps are preserved.
What solution are you recommending?
Solution is provided per specification in issue #74. This solution makes not attempt to remove the source documents after the copy. All source documents are left intact.