search

earthstar-project / earthstar

Storage for private, distributed, offline-first applications.
https://earthstar-project.org
GNU Lesser General Public License v3.0
624 stars 18 forks source link

update to crayon@3.1.0 #259

Closed AnActualEmerald closed 2 years ago

AnActualEmerald commented 2 years ago

What's the problem you solved?

Resolves #258

What solution are you recommending?

Replace crayon_chalk_aliases with the chalk aliases provided by the main crayon package

sgwilym commented 2 years ago

Can you do me a favour and tell me what the web bundle size (generated by deno task bundle) is before and after this PR?

I see another way to solve #258, which is to pin the version (which I have no idea why we didn't do before).

I also have a commit for the next version of Earthstar which completely removes crayon. If that sounds even better, we can cherry-pick it over.

AnActualEmerald commented 2 years ago

I can't get the before size because I can't run the unmodified version, but with the changes it's 270.24 kb.

The problem is that crayon_chalk_aliases itself didn't pin the version of crayon it was using, so I don't think there's an easy way to fix it that way.

If you have other changes lined up that sounds good to me, I don't have much of an opinion either way I suppose. I just wanted to get the ball rolling since even the deno docs are broken because of this, which is annoying if nothing else

sgwilym commented 2 years ago

but with the changes it's 270.24 kb.

Yeah, that sounds like it's bringing polyfills for half of Node's environment with it. I've merged another PR to remove this dependency completely. Thank you for finding this issue and submitting a fix, and apologies for the delay!