search

earthstar-project / earthstar

Storage for private, distributed, offline-first applications.
https://earthstar-project.org
GNU Lesser General Public License v3.0
637 stars 20 forks source link

Attachment sync not working on Deno runtime #297

Closed sgwilym closed 1 year ago

sgwilym commented 1 year ago

What's the problem you want solved?

Syncing attachments larger than 256kb breaks with peers syncing with PartnerWebServer / PartnerWebClient running on the Deno runtime. This is being caused by Deno not sending all messages.

Is there a solution you'd like to recommend?

For the time being users should stick to Deno 1.26.2, which does not drop WebSocket messages.

Deno need to fix their WebSocket implementation. I have created a issue for these unsent message: https://github.com/denoland/deno/issues/17332

Reproduction case: https://github.com/sgwilym/deno-ws-bug-repro

sgwilym commented 1 year ago

Seems like this will be fixed in Deno 1.30 thanks to this: https://github.com/denoland/deno/pull/17480