earthstar-project / earthstar

Storage for private, distributed, offline-first applications.
https://earthstar-project.org
GNU Lesser General Public License v3.0
623 stars 18 forks source link

Stricter share address validation #312

Closed sgwilym closed 1 year ago

sgwilym commented 1 year ago

What's the problem you solved?

parseShareAddress would incorrectly parse invalid shared addresses (e.g. +gardening.abcde as valid).

What solution are you recommending?

Changed the share address pubkey validation rules to be the same as those for user keypair pubkeys, and updated a lot of tests which were using invalid share addresses.