earthstar-project / earthstar

Storage for private, distributed, offline-first applications.
https://earthstar-project.org
GNU Lesser General Public License v3.0
623 stars 18 forks source link

Interpret co-existing non/ephemeral hosted shares in ExtensionServerSettings #316

Closed sgwilym closed 1 year ago

sgwilym commented 1 year ago

What's the problem you solved?

If a share was specified to be hosted both ephemerally and non-ephemerally, this would cause unexpected behaviour like a share not being removed or added to a server's Peer as it should be.

What solution are you recommending?

Implemented behaviour following the updated server settings spec, so that if both ephemeral and non-ephemeral docs exists and at least one of them has a non-empty text field, then that share should be hosted.