cinnamon-bun
commented
4 years ago Thanks for the report!
That's the right usage (assuming author.address is a string).
...I haven't tested this in the browser yet. Since the error is coming from node_modules/buffer I'm guessing it's related to the browserification of node Buffers into browser ArrayBuffers. Maybe readUInt32BE isn't supported in the browser polyfill. I think sha256 is working so it's not that (if signing documents works, sha256 works).
How are you bundling this, is it browserify or webpack?
Can you get a more detailed traceback?
Speed
It should be very fast to run once, the problem is running it for every rendered React component over and over.
Faster hash function
We should switch from sha256 to md5 or something even faster. This isn't security critical.
Wait for sodium to load WASM
Investigate this note about waiting for sodium to load its WASM module. Is the slowness only temporary until WASM is loaded, or does it get stuck with the slow version if we use it without waiting?
Memoize
Memoizing / caching the function should fix it, but it will still be slow on the first render.
Something like:
let colorCache = {} // mapping from author address to color string
let authorToColor(author: string): string => {
if (colorCache[author]) { return colorCache[author]; }
let color = detRandom(author, ['red', 'green', 'blue']);
colorCache[author] = color;
// todo: if cache is getting too big, randomly delete an item here
return color;
}
What's the problem you want solved?
This usage of
detChoice:Results in the following error:
Am I using it wrong somehow?
And: is this function meant to be used in the browser? Calling it in a client gives me warning messages about how resource-hungry the current tab is.