search

earthstar-project / earthstar

Storage for private, distributed, offline-first applications.
https://earthstar-project.org
GNU Lesser General Public License v3.0
634 stars 20 forks source link

OnePubOneWorkspaceSyncer should close itself when the Storage closes #81

Closed cinnamon-bun closed 3 years ago

cinnamon-bun commented 3 years ago

It should subscribe to storage.onWillClose and close itself when the Storage is closing.

cinnamon-bun commented 3 years ago

React-earthstar doesn't do this; it should be done by the syncer.

React-earthstar just closes the Storage, not the syncer:

...when deleting a workspace

...when EarthstarPeer component is going away or setStorages is called