Closed sgwilym closed 3 years ago
Updated based on the comments above and further discussion, screengrab below.
Looks good!
Here's some opinions, or feel free to just merge it
"Reveal dangerous settings" sounds obscure, it would be nice if it described what was in there like "Show controls for data deletion" so people can find it more easily. I don't want people to feel like we're making it hard to delete your data out of trickery... we just don't want it to happen by accident, and we want to reduce clutter.
Delete my data headline --> Delete all my data from +gardening. The button text would now be redundant and maybe could be shortened. It seems like having the headline be more clear is better than putting the clarity in the button which is grayed out and hard to read at first.
Forget this workspace headline --> Remove +gardening from this browser
I tried out your suggestions:
I feel this makes the headlines are a little long, to the point where they seem like very big paragraphs. But I like how it means I can make the button label shorter, and have a more compact layout instead. One consideration is that the DeleteMyDataForm can be used as a standalone component (sans headline), so you want that context someplace.
For now I'm going to just change the reveal settings label as you suggested, and will keep a close eye on this.
Updates Earthstar to 5.7.6, adds a DeleteMyDataButton, and puts it in the danger zone of workspace settings.