earthstar-project / willow-rs

Implementations of the Willow family of specifications in Rust.
https://willowprotocol.org
Apache License 2.0
23 stars 1 forks source link

Remove `.get` fn names, use third-person in docs #44

Open Frando opened 1 month ago

Frando commented 1 month ago

Hi, while starting to work with willow-rs I noted some things where the codebase differs from the rust naming conventions and documentation conventions:

If there aren't strong reasons for deviating from the convention, I found it to be quite helpful in my coding experience to just stick with it for general consistency and bikeshed avoidance.

AljoschaMeyer commented 1 month ago

Those are on me, I think. I didn't know about those conventions, and these are how I do them usually (exactly for general consistency =D). But I personally am happy to defer to the wider conventions of the rust ecosystem on these points.