Add linux aarch64 wheel build support

earwig / mwparserfromhell

A Python parser for MediaWiki wikicode

https://mwparserfromhell.readthedocs.io/

MIT License

741 stars 74 forks source link

Add linux aarch64 wheel build support #276

Closed odidev closed 3 years ago

odidev commented 3 years ago

Add linux aarch64 wheel build support.

Related to https://github.com/earwig/mwparserfromhell/issues/275 @earwig Could you please review this PR?

coveralls commented 3 years ago

Coverage remained the same at 99.168% when pulling e1df071ff0981e50568362111d869a1a809cc743 on odidev:odidev_mwparserfromhell into dcf7ba4e79e8c606f6380846b4ef9b5116b3c942 on earwig:develop.

legoktm commented 3 years ago

Very cool! Did you test the wheels generated by this on an aarch64 platform to make sure they work?

The use of QEMU rather than cross compiling or using a proper aarch64 runner is interesting, but it seems like that's what pypa does too: https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation

odidev commented 3 years ago

Very cool! Did you test the wheels generated by this on an aarch64 platform to make sure they work?

Yes, I have tested the generated wheels and they are working fine.

The use of QEMU rather than cross-compiling or using a proper aarch64 runner is interesting, but it seems like that's what pypa does too: https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation

Yes, the pypa also uses qemu with cibuildwheel as arm64 is not directly supported in github actions and currently there is no tool for cross-compilation.

earwig commented 3 years ago

Thanks!