earwig / mwparserfromhell

A Python parser for MediaWiki wikicode
https://mwparserfromhell.readthedocs.io/
MIT License
741 stars 74 forks source link

Implicit fallthrough intended? #325

Closed r-barnes closed 1 month ago

r-barnes commented 1 month ago

Is the implicit fallthrough at this line intentional, or should it be a break?

earwig commented 1 month ago

It’s intended. This is an error handling case where one of so or sc failed to allocate so we fall through to clean up the closing tag and propagate the error by returning NULL.