search

earwig / mwparserfromhell

A Python parser for MediaWiki wikicode
https://mwparserfromhell.readthedocs.io/
MIT License
730 stars 74 forks source link

setup.py AttributeError with python-2.6.8 #45

Closed cariaso closed 10 years ago

cariaso commented 10 years ago

Similar to issue #44 it seems that 37003d2 changes line 13 of compat.py

causing

python setup.py install Traceback (most recent call last): File "setup.py", line 26, in from mwparserfromhell import version File "/home/ec2-user/codetree/master/rrb/snpedia/bots/mwparserfromhell/mwparserfromhell/init.py", line 37, in from . import (compat, definitions, nodes, parser, smart_list, string_mixin, File "/home/ec2-user/codetree/master/rrb/snpedia/bots/mwparserfromhell/mwparserfromhell/compat.py", line 13, in py3k = sys.version_info.major == 3 AttributeError: 'tuple' object has no attribute 'major'

under

Python 2.6.8 (unknown, Mar 14 2013, 09:31:22) [GCC 4.6.2 20111027 (Red Hat 4.6.2-2)] on linux2

It seemed to like the previous structure sys.version_info[0] found in 53c2658 but not the sys.version_info.major found in 37003d2 as that named syntax was introduced in 2.7

earwig commented 10 years ago

Well... you're right, except that's not the only thing breaking 2.6 compatibility. I'm using a lot of features that were only added in 2.7+, like dict comprehensions. I've never tried to support 2.6 because I don't seen the point; note how it's not listed in .travis.yml or among the language classifiers in setup.py. What is holding you back from using 2.7?

Out of curiosity, I wrote a patch with the minimum changes for making v0.3.2 compatible with Python 2.6, (mostly) maintaining compatibility with later versions, and passing all unit tests: https://gist.github.com/earwig/6410005.

cariaso commented 10 years ago

What's holding me back?

vs 2.7: 2.6.8 is still the default on http://aws.amazon.com/amazon-linux-ami/

vs 3.x: boto, paramiko, fabric

but it's cool. I wasn't shocked to find 2.6.8 is considered too old. It's fine to classify this as a WONTFIX.

jfolz commented 10 years ago

Indeed, 2.6 branch will drop out of security support shortly.

earwig commented 10 years ago

Note for anyone watching this: python 2.6 is now supported following #60.