search

ease-crc / soma

The Socio-physical Model of Activities (SOMA) is a formal activity model for embodied agents that need to operate their body to generate motions that cause intentional effects in the physical and social world.
GNU Lesser General Public License v3.0
16 stars 22 forks source link

MOIN #286

Closed mrnolte closed 1 year ago

mrnolte commented 1 year ago

The Meta-Ontology for INtrospection (MOIN).

mrnolte commented 1 year ago

Not so sure why, but my Protege seemed to have restructured a lot of the ontologies I did not even touch, e.g., SOMA-OBJ. Most changes should be in SOMA-ACT and SOMA-IO, but even these should be more or less additions.

mpomarlan commented 1 year ago

Maybe a version thing? This stuff used to happen to me when I was editing with Protege 4 what Daniel was editing with Protege 5.

mpomarlan commented 1 year ago

Is this still draft?

mpomarlan commented 1 year ago

One question about SOMA-STATE.owl: ContainmentState is defined as :ContainmentState (as opposed to SOMA:LinkageState etc), meaning the namespace is SOMA-STATE as opposed to SOMA. Will the uglify script handle this and generate SOMA:ContainmentState for the merged file?

mpomarlan commented 1 year ago

Hmm, turns out the biggest diffs in the commit come from the old version being OWL Functional and the PR version being RDF/XML again.

mrnolte commented 1 year ago

Okay, now the issues should be fixed. Thanks for the review!

mpomarlan commented 1 year ago

Some strange things are happening here -- I am seeing that some of my comments from the latest review are outdated already! How come, maybe related to the conflicts on the SOMA-ACT, SOMA-OBJ, SOMA files?

mpomarlan commented 1 year ago

Ah wait no, seems I was reviewing an older commit lol. Ok lets try again.

mpomarlan commented 1 year ago

On another note, I went through the paper and made some comments or changes here and there.

mrnolte commented 1 year ago

Ah wait no, seems I was reviewing an older commit lol. Ok lets try again.

Ah, that explains the confusion!

mpomarlan commented 1 year ago

There's a few comments from the review where I ask for a couple answers and I still want those, to make sure I understand what the property chains want to do. There's a comment I forgot to place in the review apparently, but it also needs an answer. With clarifications for those, I can approve this.