Closed ayden175 closed 10 months ago
I would say to obey the paper as much as possible. With this rule of thumb, answers:
1) Yes, use "is preference of" which is a subproperty of "is quality of" 2) At the moment I do not care much one way or the other. We can keep Predilection for now. 3) Who else is using OrderedItem? If only the preference model, then let us stick to the paper names and only keep OrderedElement and its encapsulates property.
Hello there, what else needs doing here? We should close this and release soon.
I somehow missed the first comment, sorry! I've adjusted the changes accordingly. OrderItem was not used by anything else, so I renamed it and let it use encapsulates instead of hasMember. If the new changes look ok, the PR would be ready to be merged now.
Builds upons PR https://github.com/ease-crc/soma/pull/297 (Soma-Agent) to add the rest of the preference concepts. Some of the changes from Soma-Agent seem to not directly fit with some concepts of the preference model from the paper:
Preference
'is quality of' only Agent
'is preference of' only Agent
-> should'is preference of'
be added and used instead? (as a subrelation of'is quality of'
?)Preference Order
Predilection
, but that seems to be slightly different (orders situations instead of discriptions) -> shouldPredilection
be kept as well, or replaced byPreference Order
?Ordered Element
Order Item
, which seems to do the same things as far as I can tellOrder Item
useshasMember
instead of the in the paper proposedencapsulates
-> shouldOrder Item
be kept, or (partially) replaced byOrdered Element
orencapsulates
?