ease-crc / soma

The Socio-physical Model of Activities (SOMA) is a formal activity model for embodied agents that need to operate their body to generate motions that cause intentional effects in the physical and social world.
GNU Lesser General Public License v3.0
16 stars 22 forks source link

Extend preference concepts #308

Closed ayden175 closed 10 months ago

ayden175 commented 10 months ago

Builds upons PR https://github.com/ease-crc/soma/pull/297 (Soma-Agent) to add the rest of the preference concepts. Some of the changes from Soma-Agent seem to not directly fit with some concepts of the preference model from the paper:

Preference

Preference Order

Ordered Element

mpomarlan commented 10 months ago

I would say to obey the paper as much as possible. With this rule of thumb, answers:

1) Yes, use "is preference of" which is a subproperty of "is quality of" 2) At the moment I do not care much one way or the other. We can keep Predilection for now. 3) Who else is using OrderedItem? If only the preference model, then let us stick to the paper names and only keep OrderedElement and its encapsulates property.

mpomarlan commented 10 months ago

Hello there, what else needs doing here? We should close this and release soon.

ayden175 commented 10 months ago

I somehow missed the first comment, sorry! I've adjusted the changes accordingly. OrderItem was not used by anything else, so I renamed it and let it use encapsulates instead of hasMember. If the new changes look ok, the PR would be ready to be merged now.