search

easemob / react-native-chat-sdk

MIT License
2 stars 10 forks source link

Remove generate.sh #9

Closed EkaanshArora closed 2 years ago

EkaanshArora commented 2 years ago

The Readme lists this installation step:

It's not a common practice to execute a bash script when installing a react-native library, this can cause confusion for users unfamiliar with Linux. This would also be a blocker for developer building on Windows machines.

We should remove this step. When we build and release the package to npm we should make sure the CMakeLists.txt.rn is set as CMakeLists.txt, as the npm package is only used for react-native. When publishing to pub.dev it should use the flutter cmake list instead. This would remove this awkward step for the user from both platforms.

AsteriskZuo commented 2 years ago

For users, android no longer needs to perform additional operations , for developers, only need to execute yarn cpp . We will fix in version 1.0.6.